GitHub Integration: Sync only reviewed strings

It seems the GitHub integration only allows for binary configuration when pushing languages. Either a language meets the set criteria (x% revewed/translated) and is pushed, or it doesn’t and is not.

The API, however, provides the ability to grab only the reviewed strings from a resource.

Am I missing a configuration option somewhere? Is there a way to configure the GitHub integration to only push strings that have been reviewed?

2 Likes

I will note it is unsafe to pull unreviewed translations, and the lack of this option is very disappointing.

If I’d like to pull strings when 70% of them are ready, I’d like to pull only the 70% reviewed, not the 100% translated. The 30% which are translated but not reviewed may contain errors, not meet the standard of the language, or - at worst - contain offensive language. In our project where we may have dozens of community reviewers but only 1-3 trusted reviewers, the review step is crucial to providing a high quality translation experience.

Thank you for your consideration!

2 Likes

Hello! Thank you for your feedback. I have added your feature request into our product backlog. If this feature for having a way to set onlyreviewed mode into the GitHub integration is released in the future, I will let you know as soon as it is ready for you to use.

Best regards,

- Sandy

Thanks @Sandy_DLR! Would you mind updating the status of this issue?

We manage projects with relatively large resources via the Transifex GitHub App and we think this feaure is cruicial for our contributors to maintain a healthy translation culture.

At the moment, some translators might chose to translate or review 95% of the project for many reasons. Aiming to 100% translation might not be always vialble and we find that translators resort to hacks such as placing English translations, using Machine Translations in context where it’s not applicable, or even rubber stamping strings as Reviewed just to hit the 100% reviewed mark to it’s testable on their apps.

Hi :wave: By using the “Custom” option for when to push content (translated files) to GitHub, you can specify any percentage you’d like of either translated, reviewed, or proofread strings:

I believe this covers what you’d like to do. Please let me know, though, if I’ve misunderstood.

Thanks,
Ryan - Transifefx

@Ryan unless I’m misunderstanding, what you’re recommending would lead to all translated strings being pushed once the threshold of 92% reviewed is hit for a resource.

What I’d like is what @sarina mentioned before

Thanks!
- Brian

@bsmithaxim Let’s look at an example. Say there is a resource (aka source file) in a project with 2 target languages (es and fr). The languages are translated as follows:

For es:

  • 100% Translated
  • 70% Reviewed

For fr:

  • 90% Translated
  • 55% Reviewed

If the integration is set up as follows:

Then only the es translation file will be synced back to GitHub since its threshold for when to sync is 65% Reviewed, and es is at a higher percentage for reviewed (70%).

Now, please know that the es translation file will not contain ONLY the translations that have been marked as Reviewed, as we always return all of the strings… with the GitHub integration, we always return the ‘for use’ translation file:

When requesting a translation file either in the UI or via API/CLI, though, there are more options for what gets returned for the strings that aren’t marked as Reviewed. This depends on the file format (here is a link to all of the file formats we support). For example, let’s look at Key-Value JSON files:

So, are you wanting the other options besides ‘for use’ to be available in the GitHub integration?

Best,
Ryan
Sales Engineer - Transifex

This is the problem.

Yes. I want to be able to pull only the reviewed translations.

@bsmithaxim OK, got it. And, you are aware that the source strings would still be included in the translation file, but with empty translations for the strings not marked as Reviewed?

Could you explain why that would be the case? The “Download only reviewed translations” link does not behave that way.

@bsmithaxim All of the download modes work that way. Please grab a ‘for use’ translation file with only a few strings marked as Reviewed, and then grab a ‘onlyreviewed’ file and compare them.

I did that. The “only reviewed” .po file has 7 entries in it and is 2.2kB. The “for use” file has 467 and is 107kB.

OK, so the exact behavior is dependent on the file format, and what you’re saying is correct for PO files:

For anyone else reading this post, please go to the corresponding place in the documentation for the file format you’re interested in to see how it will behave.